Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playwright] Fix ignore region positioning when clipSelector is also present #150

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

omacranger
Copy link
Member

@omacranger omacranger commented Oct 10, 2024

Description

This updates the ignore regions position using the offset of the clipped element, if present, for Playwright + Storybook.

Example from Sauce Demo site:

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@omacranger omacranger merged commit 08db254 into main Oct 10, 2024
2 checks passed
@omacranger omacranger deleted the bugfix/playwright-clip-ignore branch October 10, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants